search

defunkt / github-gem

`github` command line helper for simplifying your GitHub experience.
http://github.com
MIT License
1.12k stars 188 forks source link

Ruby 1.9 update #36

Closed keithpitt closed 13 years ago

keithpitt commented 13 years ago

I've updated the gem to work under Ruby 1.9 AND Ruby 1.8.x

I've also added some extra handling around the github_user and github_token methods that tell the user what to do in the event they don't exist (like when it happened to me :D)

All the specs pass and there are no warnings in 1.9.2p136

kristianmandrup commented 13 years ago

Great stuff!!!

mdarby commented 13 years ago

Can this be merged? Anyone?

kristianmandrup commented 13 years ago

OK, I just merged it into a new ruby-1.9 branch in my repo. Take it from there ... ;) if you dare!

keithpitt commented 13 years ago

One thing to note is that the gem is still backwards compatible with 1.8

The specs pass in both ruby-1.9.2-p136 and ruby-1.8.7-p302 on my machine.

Keith

drnic commented 13 years ago

Applied, thanks everyone.