search

defunkt / jquery-pjax

pushState + ajax = pjax
https://pjax.herokuapp.com
MIT License
16.73k stars 1.97k forks source link

iOS 10 #644

Closed robmcvey closed 7 years ago

robmcvey commented 8 years ago

Someone with iOS10 already might want to test in Safari.

We've had to remove pjax completely, seems pjax:complete is never called.

Will continue to debug and update if I can.

staabm commented 8 years ago

have to test that right now, thx for the hint

mikesheppard commented 8 years ago

Yes I've tested with IOS 10 too with Safari and Chrome and confirmed it's breaking.

mislav commented 8 years ago

Thanks for the comments. In which way is this broken?

ghost commented 8 years ago

I had the same issue but updated to the most recent version of PJAX and now it works fine. We use pjax:complete too. @robmcvey are you on the latest version (last updated 16 Sep 15)?

robmcvey commented 8 years ago

@gregormck I don't think so, no. Thanks for the heads-up though.

We've opted to remove pjax completely due to the lack of activity and hanging PRs.

I'll leave the issue open for a core member to close if indeed it's a non-issue in most recent version.

ghost commented 8 years ago

@robmcvey What did you replace it with? I might do the same...

mislav commented 8 years ago

@robmcvey Do you have any tangible evidence that jquery-pjax is broken in iOS 10?

tm1000 commented 8 years ago

Updating the library to the newest in this repo fixed the issue as well. it was a simple user-agent fix they did a while back that would previously match iOS 10.x as iOS 1.x

@mislav if you are in charge of it from github maybe you should go through the PRs and see which ones work. Or give dual access to someone who wants to maintain the project. Seems like the community wants it. Please don't do what twitter did with their typeahead library and just make it abandonware.

Shigeki1120 commented 7 years ago

@tm1000 This is a noobish question but where is the newest repo located? Can you drop a link here?

Or. are you talking about pjax 1.9.6?

tm1000 commented 7 years ago

I ended up removing pjax from my project all together. The poor support from github on this project reminds me of the poor support twitter gave typeahead. I fail to see why it's so hard to push a new release with simple fixes like this (that already exist in the code!)

mislav commented 7 years ago

A new version of jquery-pjax is now tagged: https://github.com/defunkt/jquery-pjax/releases/tag/v2.0.0

Let us know if there are further iOS problems!