defunkt / jquery-pjax

pushState + ajax = pjax
https://pjax.herokuapp.com
MIT License
16.74k stars 1.97k forks source link

Adds trailing semicolon in order to avoid type errors. #697

Closed csalmeida closed 6 years ago

csalmeida commented 6 years ago

A simple semicolon that makes sure projects with other libraries or Browserify know where this pjax begins and ends.

Before pjax_type_error

After the semicolon pjax_running

csalmeida commented 6 years ago

The build has failed because of the semicolon. I guess it could be added by a task runner as well and no PR is needed.

mislav commented 6 years ago

Thanks, but your tool to bundle libraries together should be quite capable to add semicolons between them. You chould also run jquery-pjax.js through a minifier to get a version with semicolons.