defunkt / pystache

Mustache in Python
http://mustache.github.com/
MIT License
1.31k stars 308 forks source link

Is this project dead? #192

Open obfuscoder opened 7 years ago

obfuscoder commented 7 years ago

There have been no commits in the last 3 years. Issues haven't been updated in a while. Pull requests haven't been merged or discussed despite them building successfully. Mailing list is silent.

I'm very much interested in the YAML input support (PR#177).

stuaxo commented 6 years ago

Maybe am interim maintainer could be a solution http://bluesock.org/~willkg/blog/dev/html5lib_1_0.html

hugovk commented 6 years ago

Some are now using chevron:

Chevron runs in less than half the time of pystache (Which is not even up to date on the spec). And in about 70% the time of Stache (A 'trimmed' version of mustache, also not spec compliant).

https://github.com/noahmorrison/chevron

bakert commented 3 years ago

I think chevron is probably the best option but if you need a working python3 version of this library for any reason I have forked it to fix incompatibility with latest setuptools and (relatedly) dropped python2 support here – https://github.com/PennyDreadfulMTG/pystache

slhck commented 3 years ago

There's another fork that seems well-maintained at https://github.com/sarnold/pystache

Seriously though, one of the updated forks should be on PyPI … has anyone considered taking this over?

There's a process for this now: https://www.python.org/dev/peps/pep-0541/

hugovk commented 3 years ago

What do authors of the two forks @bakert and @sarnold think about applying for transfer of the name on PyPI?

bakert commented 3 years ago

@sarnold's fork looks better maintained than mine. I will probably retire mine in favor of using that. Changing it over makes sense to me if @sarnold agrees.

sarnold commented 3 years ago

I guess that depends on the level of interest? I was actually thinking about moving some things soon (out of personal to FOSS org) but I'm living off of negative time right now. The pypi thing is on my todo list, I don't have anything there yet; I'd be up for co-maintenance (if that's even a thing) if @bakert is interested. That's about the best I can do for now...

bakert commented 3 years ago

We have extensions to pystache that make it faster (which should perhaps have been a PR against the library) and we've also hacked it to do our i18n so we're pretty deeply invested in there being a working library out there – https://github.com/PennyDreadfulMTG/Penny-Dreadful-Tools/blob/master/shared_web/template.py. Moving off pystache would be pretty painful. All that said our project is volunteer-only with only two devs giving significant time to it. But co-maintenance could definitely be a thing.

sarnold commented 3 years ago

Sounds like maybe I should just open a giant PR? The main reason for my maintenance fork in the first place was/is reviving gitchangelog, and other than that, I don't think I have any other packages that depend on pystache (i should really go check that...).

bakert commented 3 years ago

Giant PR is acceptable!

sarnold commented 3 years ago

I did say it would be big... Also I got distracted with other stuff <cough>work</cough> but I'm almost ready for some squashing after this: https://github.com/sarnold/pystache/pull/8

Hopefully you enjoy automation; I should also mention the coverage workflow needs a(n orphan) branch named badges to maintain/display coverage data/badge. You even get to modify the PR comment msgs in the workflow (bonus!). <= uses only github actions (no external integrations/services)

bakert commented 3 years ago

I love automation :) Awesome to see this moving.

Is the goal that https://github.com/sarnold/pystache be the canonical/pypi repo at the end of this? Or are you going to send a giant PR against our fork? Or something else?

sarnold commented 3 years ago

@bakert is this the right place? https://github.com/PennyDreadfulMTG/pystache/pull/1

or did you want that in your personal github?

bakert commented 3 years ago

That's the right place. There's a reasonable chance other devs from that project will get involved.

On Mon, Oct 18, 2021 at 9:43 AM Steve Arnold @.***> wrote:

@bakert https://github.com/bakert is this the right place? PennyDreadfulMTG#1 https://github.com/PennyDreadfulMTG/pystache/pull/1

or did you want that in your personal github?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/defunkt/pystache/issues/192#issuecomment-945962679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAMBIBM6AY3OKFIWUBTVLUHRFC5ANCNFSM4DWNW37Q .

bakert commented 3 years ago

Sorry it took me a few days to check this out. Your big PR is now merged. Is there more to come or are we in a good place now? Should we publish a new version with a new version number?

slhck commented 3 years ago

Thanks for your efforts! I think what would be best us if you could kick off the process to take over the project on PyPI so that a pip install will find your updated fork. This requires the original project to be dead and the maintainers to be unresponsive, which both seems to be the case.

bakert commented 3 years ago

I have made an official request to take over here - https://github.com/pypa/pypi-support/issues/1422

Tagging @defunkt in case they can pipe up to say it's ok to transfer the name.

slhck commented 2 years ago

For anyone else coming here, this project is now officially no longer the source for PyPI, and you can find the newest releases here:

https://pypi.org/project/pystache/

obfuscoder commented 2 years ago

Thanks for moving this forward. What do you think, shall I close the issue or keep it open so that others will find it?

slhck commented 2 years ago

I think you can close it. It's only a problem for legacy installations. New users should automatically get the right version via PyPI.