search

defuse / php-encryption

Simple Encryption in PHP.
MIT License
3.78k stars 308 forks source link

"decryptResourceInternal" method visibility public #503

Open kronthto opened 1 year ago

kronthto commented 1 year ago

I was wondering, why is this public/exposed, all the other "Internal" methods appear to be private. I couldn't find external references to it. Just an oversight?

https://github.com/defuse/php-encryption/blob/90060874f868d0711890e67456b4f26930fc478f/src/File.php#L457

It's not a big problem though, and changing this risks breaking integrations in the wild that are using it directly now.

defuse commented 1 year ago

Good point, it indeed should have been private. Thanks!