search

defuse / php-encryption

Simple Encryption in PHP.
MIT License
3.78k stars 308 forks source link

Made PHPUnit tests pass in PHP 8.0, PHP 8.1 and PHP 8.2 #504

Closed boenrobot closed 1 year ago

boenrobot commented 1 year ago

Made PHPUnit tests pass in PHP 8.0, PHP 8.1 and PHP 8.2, by supporting PHPUnit 10, PHPUnit 8 and PHPUnit 5, complete with config files, one of which is explicitly picked by phpunit.sh based on the PHPUnit version previously determined based on the PHP version. This required dropping support for PHPUnit 4, but that is OK, as PHPUnit 5 still supports PHP 5.6, that being the earliest PHP version supported by this library.

Also fixed the broken exception message assertions in two of the tests, so that tests now pass.

defuse commented 1 year ago

OH MY GOD YOU ARE A HERO THANK YOU THANK YOU THANK YOU HOW DO I SEND YOU MONEY?

Getting this to work has been on the back of my mind for like a year and was really stressing me out.

YOU ARE AMAZING THANK YOU!

boenrobot commented 1 year ago

If you want to send me money, here's my paypal link:

https://www.paypal.com/paypalme/boenrobot

I do see now with your copied PR that Travis fails for other reasons. Huh. If you could switch to github actions or otherwise enable travis on all PRs, I could debug those as well. The only thing I actually tested was running the test suite locally.