search

defuse / php-encryption

Simple Encryption in PHP.
MIT License
3.79k stars 307 forks source link

Make PHPUnit tests pass in PHP 8.0, PHP 8.1 and PHP 8.2 thanks to @boenrobot #506

Closed defuse closed 1 year ago

defuse commented 1 year ago

Now I just have to make it work on Travis lol, wtf is even happening

defuse commented 1 year ago

Oh I'm dumb that's github actions not travis

defuse commented 1 year ago

My god Travis has really gone downhill.... okay I got it reconnected let's see if this builds

codecov[bot] commented 1 year ago

Codecov Report

Merging #506 (90c263c) into master (9006087) will increase coverage by 0.36%. The diff coverage is 94.73%.

@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
+ Coverage     89.06%   89.43%   +0.36%     
- Complexity      210      217       +7     
============================================
  Files             9        9              
  Lines           933      965      +32     
============================================
+ Hits            831      863      +32     
  Misses          102      102
Impacted Files Coverage Δ
src/File.php 85.22% <93.33%> (+0.88%) :arrow_up:
src/Core.php 78.28% <100.00%> (+2.09%) :arrow_up:

... and 3 files with indirect coverage changes

defuse commented 1 year ago

[deleted bad information]

defuse commented 1 year ago

The bug in Travis's 8.2 build is that https://storage.googleapis.com/travis-ci-language-archives/php/binaries/ubuntu/16.04/x86_64/php-8.2.tar.bz2 is missing a bunch of binaries, including composer:

image

defuse commented 1 year ago

OMG now Travis-CI is completely broken because I didn't realize I was on a trial plan and ran my credits into the negative, and some sort of bug is preventing it from switching on the free OSS builds. Edit: Oh, you have to email them now to get OSS credits. I paid $69.

defuse commented 1 year ago

The tests are about to pass! :crossed_fingers: