search

deg / re-frame-firebase

Re-frame wrapper around Google's Firebase database
95 stars 32 forks source link

Allow passing Firestore settings #22

Closed smogg closed 6 years ago

smogg commented 6 years ago

Right now the app will display the following warning when Firestore is used:

screen shot 2018-08-13 at 18 26 38

This PR introduces another key to the firebase/init function where one can pass the requested Firestore setting:

(firebase/init :firebase-app-info  firebase-app-info
               :firestore-settings {:timestampsInSnapshots true}
               :get-user-sub       [:user]
               :set-user-event     [:set-user])

In addition to that, I've also cleaned up the Firestore example a little bit.

deg commented 6 years ago

Oh, damn! Github made me review each of your commits individually, but then put a "View changes" by each one showing the collective changes. Gag me!

Please read them with the understanding that each of my four review comments referred to one of your commits, in order.

smogg commented 6 years ago

@deg thanks for the review. The PR now includes one commit, and I've addressed your comments.