Twitter :redirect auth fails quietly on existing user

deg / re-frame-firebase

Re-frame wrapper around Google's Firebase database

95 stars 32 forks source link

Twitter :redirect auth fails quietly on existing user #5

Closed deg closed 7 years ago

deg commented 7 years ago

If a user has previously logged via another authorization provider, then :redirect authorization via Twitter will fail with no error or warning.

To reproduce:

Delete your user from the firebase app
Login with github
Logout
Login with Github, redirect. You will see no error, but not be logged in.

It is likely that the best (or only) way to fix this problem is by implementing account linking. See issue #3 Link Multiple Auth Providers

pbzdyl commented 7 years ago

For the record it looks that com.degel.re-frame-firebase/init would need to check for firebase.auth.Auth#getRedirectResult and handle the auth error in .catch.

deg commented 7 years ago

Thanks!

pbzdyl commented 7 years ago

If you don't mind I can submit a patch soon!

deg commented 7 years ago

Cool, thanks.