search

deg0nz / MMM-PublicTransportBerlin

MagicMirror module to display public transport in Berlin and Brandenburg with BVG Hafas data.
MIT License
40 stars 20 forks source link

Upgrade hafas-client to v6 + some rework #157

Closed KristjanESPERANTO closed 1 year ago

KristjanESPERANTO commented 1 year ago

It works fine for me. Since it's a major change, it would be good if it was tested on other machines as well.

deg0nz commented 1 year ago

I just checked. I need some time to look over it. I currently have no MM installed here, because I moved. So please bare with me :)

rejas commented 1 year ago

A quick check with my config worked too. Not much time to make a code review though (👶)...

KristjanESPERANTO commented 1 year ago

Sorry, I should have kept the PR smaller.

rejas commented 1 year ago

Sorry, I should have kept the PR smaller.

So, maybe cut some easy parts (like typos, documentation updates) into seperate PRs (that we can merge faster) so that the v6 stuff is easier to check?

KristjanESPERANTO commented 1 year ago

I've moved most of the changes irrelevant to the hafas-client upgrade to PR #161 :slightly_smiling_face:

When #161 is done, I'll adjust this PR.

KristjanESPERANTO commented 1 year ago

There are still a lot of changes, but at least it should be a bit more manageable now than before.