search

deg0nz / MMM-PublicTransportBerlin

MagicMirror module to display public transport in Berlin and Brandenburg with BVG Hafas data.
MIT License
40 stars 20 forks source link

Shorten station name in the title as well #205

Closed Jargendas closed 6 months ago

Jargendas commented 6 months ago

Hi, thanks for your work, I've been using your module for quite some time now and it's great, especially during the strikes atm ;) I have a very small suggestion for improvement: I think it would make sense that not only the station names for the destination is shortened, but also the station name in the title row. No need to tell me I'm in Berlin again. Before the change, it said for me "Sundgauer Str. (Berlin)". Now it just says "Sundgauer Str." in the title.

rejas commented 6 months ago

Could you fix the tests?

Jargendas commented 6 months ago

I believe the failing test has nothing to do with my changes, does it? It's asking for a package-lock file, which is not present on the master either.

rejas commented 6 months ago

@KristjanESPERANTO could that be related to your PR ?

Jargendas commented 6 months ago

Yes, that's the issue. I read up on it and it seems you are supposed to always commit package-lock. https://dev.to/adamklein/package-lock-json-in-git-or-not-50l5

KristjanESPERANTO commented 6 months ago

You're right. I'm fixing this now.

KristjanESPERANTO commented 6 months ago

I have successfully tested the new function and find it very good. Thank you very much!

Sorry for causing trouble with the tests.