search

deg0nz / MMM-PublicTransportBerlin

MagicMirror module to display public transport in Berlin and Brandenburg with BVG Hafas data.
MIT License
40 stars 20 forks source link

Reduce linter problems #77

Closed KristjanESPERANTO closed 2 years ago

KristjanESPERANTO commented 2 years ago

I have reduced the number of linter problems from 215 to 8. I have had almost all of them fixed automatically. The others were minor, so I don't expect any impact on functionality 🙂

The remaining 8 problems would need a closer look.

deg0nz commented 2 years ago

Hey you guys, thanks again for your effort!

It is forseeable, that I won't have much time for maintenance until at least august. Should/may I add one or both of you as maintainers for this repo?

Since you both have done a lot of stuff here, I trust you to behave wisely and in my interests :)

rejas commented 2 years ago

I can take that responsibility :-) I promise I will only maintain and not feature-bust it :-D

KristjanESPERANTO commented 2 years ago

I would be open too, but I'm sure it's enough for now if @rejas becomes an additional maintainer 🙂

KristjanESPERANTO commented 2 years ago

Thanks for the trust to make me a maintainer too, @deg0nz! 🙂

rejas commented 2 years ago

Just a quick question: Does anyone else get this error when running the linter script and using node > v14 ?

Error: Cannot find module '/home/veeck/Projekte/MMM-PublicTransportBerlin/node_modules/json-schema-traverse/index.js'. Please verify that the package.json has a valid "main" entry

rejas commented 2 years ago

Nevermind, a clean reinstall fixed it...