search

degdigital / magento2-customreports

Magento 2 module that allows an admin panel user to create new reporting grids via SQL statements.
67 stars 40 forks source link

column filters to allow datetime (and potentially more) #37

Open ProxiBlue opened 2 years ago

ProxiBlue commented 2 years ago

Add ability to define column filters via mysql comment block in SQL edit

ProxiBlue commented 2 years ago

ref: https://github.com/degdigital/magento2-customreports/issues/29

peterjaap commented 1 year ago

@jantzenw could you take a look at this?

jantzenw commented 1 year ago

Personally I think this kind of behavior would ideally have its own, new field on the report, similar to how CleanSql reports operated in Magento 1 with its "grid_config" JSON field. That seems cleaner than having comments that need to be parsed out.

https://github.com/kalenjordan/custom-reports/blob/master/app/code/community/Clean/SqlReports/sql/Clean_SqlReports/upgrade-0.1.1-0.1.2.php#L7

https://github.com/kalenjordan/custom-reports/blob/4192e89744175c1d5ede85ec7de5b6478187784d/app/code/community/Clean/SqlReports/Block/Adminhtml/Customreport/View/Grid.php#LL87C10-L87C16