Issue Fixed Related to Delete List Items from auto export Report setting and associated config setting for Cron.

degdigital / magento2-customreports

Magento 2 module that allows an admin panel user to create new reporting grids via SQL statements.

67 stars 40 forks source link

Issue Fixed Related to Delete List Items from auto export Report setting and associated config setting for Cron. #40

Closed Ravikr139 closed 1 year ago

Ravikr139 commented 1 year ago

Issue Fixed to remove auto export Report list and config setting for Cron.

Ravikr139 commented 1 year ago

Issue Fixed to remove auto export Report list and config setting for Cron. @peterjaap

peterjaap commented 1 year ago

@Ravikr139 what issue are we talking about?

Ravikr139 commented 1 year ago

@peterjaap issue specially related to the deletion of existing automated export settings (Report->Automated Exports). It was not working there. This issue has been fixed in this.

peterjaap commented 1 year ago

Right, thanks!

peterjaap commented 1 year ago

I'm not the maintainer however, so I can't merge this. LGTM however.

@jantzenw @brobie

Ravikr139 commented 1 year ago

@jantzenw @brobie

Please Review and merge this PR. It will fix the major issue related to delete export list setting.

jantzenw commented 1 year ago

This PR is being merged. This issue is also fixed in v3.1.1+ (albeit slightly differently).

Side note, the master branch is out of date. It is purposely not being updated much because this repo lacked tags for many years, causing some users to install the extension as "dev-master", so updates to the master branch could have serious consequences.