degeron / qmmp

Automatically exported from code.google.com/p/qmmp
0 stars 0 forks source link

QMake: Need short fixes on .pro files #586

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Comparing with CMakeLists.txt, *.pro files has slightly outdated.
The current qmake *.pro tree does not provide or missed following
actions:
 *1) Generate and install pkgconfig *.pc files
 *2) Install *.png image files of kdenotify plugin
 *3) Install qmmp_dir.desktop file of app/
 *4) Install scalable *.svgz files of app/
 *5) Install PlayListFormats plugin at the proper path 

/patch-create_pc_file
1) I am not certain about the way of generating pkgconfig file,
  but the method is very simple to require adding few lines:
    CONFIG += create_pc create_prl no_instal_prl
    QMAKE_PKGCONFIG_NAME = qmmpui
    QMAKE_PKGCONFIG_DESCRIPTION = qmmp user interface library
    QMAKE_PKGCONFIG_REQUIRES = QtCore QtGui qmmp
    QMAKE_PKGCONFIG_DESTDIR = pkgconfig
  When these lines are processed, the pkgconfig file is created
  at SRCDIR/lib/pkgconfig/qmmpui.pc during Makefile is generated.

/patch-General__kdenotify.pro
2) Image file names of app_icon.png and empty_cover.png are listed
  in the images.files variable of kdenotify.pro, but are ignored
  because their path images/ is missing.

/patch-app.pro
3) The entry qmmp_dir.desktop is missing at app.pro
4) qmmp.svgz and qmmp-simple.svgz are missing at app.pro

/patch-PlayListFormats-path
5) Some entries are wrong path with 'PlaylistFormats/', and
  QMAKE_CLEAN target of mp3playlistformat is General/.

Original issue reported on code.google.com by liangtai.s4@gmail.com on 12 Apr 2013 at 10:51

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by trialuser02 on 29 May 2013 at 4:33

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r3494.

Original comment by trialuser02 on 29 May 2013 at 7:51

GoogleCodeExporter commented 9 years ago
Uploaded. Thank you!

Original comment by trialuser02 on 29 May 2013 at 7:51