degica / barcelona

PaaS built on top of AWS
MIT License
52 stars 6 forks source link

Adding processing time fields to nginx logs #770

Closed Maduranga closed 1 year ago

Maduranga commented 1 year ago

Purpose

This PR adds processing times to the Nginx log. This helps us debug request delays.

Context: https://degica.slack.com/archives/CTG3QN2C9/p1681720334180109

essa commented 1 year ago

@Maduranga These fields are from a module, ngx_http_upstream_module. Does reverse proxy contain this module?

essa commented 1 year ago

It seems not.

[root@ip-10-101-2-148 ~]# docker run -ti  --entrypoint /bin/bash  public.ecr.aws/degica/barcelona-reverse-proxy
root@b573bfba4c94:/# nginx -V
nginx version: nginx/1.22.1
built by gcc 10.2.1 20210110 (Debian 10.2.1-6)
built with OpenSSL 1.1.1n  15 Mar 2022
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -ffile-prefix-map=/data/builder/debuild/nginx-1.22.1/debian/debuild-base/nginx-1.22.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'
root@b573bfba4c94:/#
Maduranga commented 1 year ago

@essa Thank you. It seems ngx_http_upstream_module is part of the core modules so we do not need to install it.

Maduranga commented 1 year ago

I see. Let me check.

essa commented 1 year ago

I tested it by invoking nginx with a modified config in the docker image. It started with "$upstream_connect_time". The nginx in the public docker image contains ngx_http_upstream_module.