search

degica / barcelona

PaaS built on top of AWS
MIT License
52 stars 6 forks source link

increase the startup timeout for the run pack #811

Closed davidsiaw closed 5 months ago

davidsiaw commented 5 months ago

When the ECS_IMAGE_PULL_BEHAVIOR is default and the image is large, starting a console can take more time than 30 seconds. This will lead to failure to start the container. This just loosens that startup timeout.

How to check that this is working?

Only the logic has changed. The manual test riggings no longer work so need to be updated. But the test mocks the process lister and checks that the process does what it does so go test needs to be good enough for now. I added more modern go-modules so you can use it if you have go installed locally. Otherwise brew install go.

  1. cd dockerfiles/run-pack
  2. go build
  3. go test
  4. should pass.
degikko commented 5 months ago

@ochko can you help us review this PR, please?