degica / dockerfiles

Dockerfile collection
1 stars 1 forks source link

Add job to clone images to our repo #16

Closed matafc closed 1 year ago

matafc commented 1 year ago

This is to help with the current work on using self-hosted github runners.

This change clones selenium chrome images so we can use in our github runners without hitting pull limits.

After creating the public repositories in our AWS ECR, I confirmed we can pull the images build for the PR branch without logging in to docker or aws.

➜  degica docker pull public.ecr.aws/degica/selenium-standalone-chrome:test-clone-remote-chrome-4.7.1
test-clone-remote-chrome-4.7.1: Pulling from degica/selenium-standalone-chrome
Digest: sha256:32c0133aab5ce9292cecdce558cf21e748a40ece09685082dc41f696cdd14ece
Status: Image is up to date for public.ecr.aws/degica/selenium-standalone-chrome:test-clone-remote-chrome-4.7.1
public.ecr.aws/degica/selenium-standalone-chrome:test-clone-remote-chrome-4.7.1
➜  degica docker pull public.ecr.aws/degica/selenium-standalone-chrome-debug:test-clone-remote-chrome-3.141.59
test-clone-remote-chrome-3.141.59: Pulling from degica/selenium-standalone-chrome-debug
Digest: sha256:0c59037d0a095d7edb7b956e95a24573a6a441654a1acd2f7bebad048ef16e65
Status: Downloaded newer image for public.ecr.aws/degica/selenium-standalone-chrome-debug:test-clone-remote-chrome-3.141.59
public.ecr.aws/degica/selenium-standalone-chrome-debug:test-clone-remote-chrome-3.141.59

After this is merged, we will be able to use the images public.ecr.aws/degica/selenium-standalone-chrome:4.7.1 and public.ecr.aws/degica/selenium-standalone-chrome-debug:3.141.59 anywhere.

Edit: added degicigel/echo repo as well.

degikko commented 1 year ago

@barom1991 can you help us review this PR, please?