search

degica / dockerfiles

Dockerfile collection
1 stars 1 forks source link

Add new buildpack with older openssl version #9

Closed Resonious closed 3 years ago

Resonious commented 3 years ago

Turns out bizstation doesn't work with OpenSSL 1.1.1, but does work with 1.1.0. I guess OpenSSL doesn't use semantic versioning!

Since Ruby does use semantic versioning, I decided to bump Ruby from 2.7.2 to 2.7.3 as well. Since it's a bit of a pain to update our Ruby version, I figured I'd use this as an opportunity to do so.

How to test

  1. docker build rails-buildpack/2.7.3-old-openssl -t bp-test
  2. docker run --rm -it bp-test bash
  3. ruby --version - confirm that it is 2.7.3.
  4. openssl version - confirm that it is 1.1.0.
degicat commented 3 years ago

@thoiberg can you help us review this PR, please?

degicat commented 3 years ago

@Metallion can you help us review this PR, please?

thoiberg commented 3 years ago

@Resonious is it ok that it's using the 1.1.1d library? image

Resonious commented 3 years ago

Aha, yeah, the version Andreas used said

OpenSSL 1.1.0l  10 Sep 2019 (Library: OpenSSL 1.1.1d  10 Sep 2019)

, so I think we're good.

Metallion commented 3 years ago

Also maybe we can remove the two trailing empty lines?

Resonious commented 3 years ago

@Metallion Thanks! The production consoles are actually running directly on ruby:2.7.2-slim, which likely does not have wget (while the non-slim ones do). So I will have to amend the Dockerfile in hats as well. Come to think of it, this change might not be strictly necessary since we don't hit BizStation until after build, but I'll keep it for the Ruby minor version bump :sunglasses: