search

degica / kaiser

Commandline Gem that allows you to work with web apps better
https://tech.degica.com/kaiser/
MIT License
12 stars 1 forks source link

Platform parameter for database #69

Closed davidsiaw closed 2 years ago

davidsiaw commented 2 years ago

Some database containers do not have ARM64 versions. This allows us to specify a platform for them in those cases.

Edit: A large amount of this PR is rubocop (rubocop has changed a lot in the intervening time) so if you feel like theres a lot of clutter I can highlight the bits that are actually the changes.

nekogami commented 2 years ago

🐈 🐈 🐈

degicat commented 2 years ago

@kubenstein can you help us review this PR, please?

davidsiaw commented 2 years ago

@kubenstein thanks for your review. I made the changes. I moved to make the default '' instead of nil because I want to avoid nil wherever I can, but even though we still have to handle it where user input is involved.

davidsiaw commented 2 years ago

@kubenstein 🙏