search

degica / spree_komoju

Spree extension for using the Komoju Payments API.
https://komoju.com/
BSD 3-Clause "New" or "Revised" License
6 stars 11 forks source link

Add PayEasy to spree_komoju #26

Closed rramsden closed 8 years ago

rramsden commented 8 years ago

This continues the work @camelmasa did in https://github.com/komoju/spree_komoju/pull/4

I've rebased his work on master and added some additional methods to make it work with the latest Spree. You can see my additional changes below.

rramsden commented 8 years ago

@camelmasa Do you mind reviewing this?

camelmasa commented 8 years ago

@rramsden Thank you for continuing :clap: I'll review that now.

camelmasa commented 8 years ago

@rramsden We need to add some locale words :dancers:

spree_demo_site

app/views/spree/orders/_pay_easy.html.erb too.

Could you add locale of English :question: then I'm going to add locale of Japanese.

rramsden commented 8 years ago

@camelmasa I'll try and add now

rramsden commented 8 years ago

@camelmasa Could you take another look. Spree exception handling is very strange...

image

camelmasa commented 8 years ago

@rramsden LGTM :+1: Great work :star2: Can I merge it :question: Then I'd like to add japanese locale on other PR.

rramsden commented 8 years ago

@camelmasa Looks good to merge. Please add Japanese locales when you have time :pray: