search

dehesselle / virtctl

start/stop libvirt-based VMs with systemd
MIT License
11 stars 1 forks source link

Fixed problem with virsh response evaluated in ExecStop depending on locale. #10

Closed flochir closed 2 years ago

flochir commented 2 years ago

Hey @dehesselle, thanks for this useful piece of systemd Fu!

I ran into a minor problem settings things up. virsh output depends on the locale used:

$LANG=de_DE.UTF-8 virsh domstate testdom
laufend

$LANG=C virsh domstate testdom
running

Evaluating it in the ExecStop call then leads to an error.

dehesselle commented 2 years ago

Hi, thanks for the contribution! I'll take a look at this on the coming weekend.

dehesselle commented 2 years ago

I am very sorry for taking so long. Looking at this now, I don't understand why ever decided to not merge this directly, as the changes are easy to understand. My sincere apologies.

I've changed your commit message slightly (I'm a big fan of https://cbea.ms/git-commit/).

flochir commented 2 years ago

Don't worry, and thanks for the link!