dehnavi / get-simple-cms

Automatically exported from code.google.com/p/get-simple-cms
GNU General Public License v3.0
0 stars 0 forks source link

CKEditor "Link" Tab on Insert Image Popup #173

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When you are in CKeditor and want to add a hyperlink (internal or external) to 
an image, you need to go to the second tab in the image-window, but there you 
also get the chance to browse for an image. You actually should see the dialog 
you see when you click on the add-link button. 

See attachment on this post to see how it should look: 
http://get-simple.info/forum/post/10730/#p10730

Original issue reported on code.google.com by ccagle8 on 21 Mar 2011 at 12:43

GoogleCodeExporter commented 9 years ago
I'd like to suggest closing this issue as WontFix, because if user wants to add 
link on image to page from website, he could add image, select it in CKEditor 
and press "Link" button to select link.

Original comment by jos...@gmail.com on 24 Mar 2011 at 10:50

GoogleCodeExporter commented 9 years ago
agreed - but should we hide that tab then? It is a little confusing

Original comment by ccagle8 on 24 Mar 2011 at 12:20

GoogleCodeExporter commented 9 years ago
I think it might be useful if user adds image thumbnails and wants to link it 
to image.

Original comment by jos...@gmail.com on 24 Mar 2011 at 12:25

GoogleCodeExporter commented 9 years ago
agreed that if a user wants to add a link, this is the tab they would use - but 
right now the tab makes no sense. It gives you a browse server button instead 
of the screenshot that was posted in the forums in the link above

Original comment by ccagle8 on 28 Mar 2011 at 3:00

GoogleCodeExporter commented 9 years ago
This wont be done for 3.1 
Wwill try and get it completed for 3.2

Original comment by MichaelS...@gmail.com on 4 Jan 2012 at 3:09

GoogleCodeExporter commented 9 years ago
this is not a GetSimple Issue, it is an issue of the CKEditor configuration 
if somebody wants this rare configuration, he can change that in a custom 
config file.

it is part of the dialogue definition and gets done here:

// see 
http://docs.cksource.com/CKEditor_3.x/Developers_Guide/Dialog_Customization

CKEDITOR.on( 'dialogDefinition', function( ev )
    {
        // Take the dialog name and its definition from the event data.
        var dialogName = ev.data.name;
        var dialogDefinition = ev.data.definition;

        // Check if the definition is from the dialog we're
        // interested on (the Link dialog).

if ( dialogName == 'image' )
        {
            // FCKConfig.ImageDlgHideAdvanced = true    
            dialogDefinition.removeContents( 'advanced' );
            // FCKConfig.ImageDlgHideLink = true
            dialogDefinition.removeContents( 'Link' );
        }

    });

Original comment by petusc...@googlemail.com on 24 Jan 2012 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by ccagle8 on 22 Feb 2012 at 3:49