Open Dexteroo7 opened 6 years ago
I noticed that when an InterruptedException is caught, we set the interrupt flag back using Thread.currentThread().interrupt(). Should we not also throw some exception
@Dexteroo7 can you point to the where that's happening and maybe a description of what the issue is; the client uses a background thread which means some exceptions need to be propagated differently and just throwing won't always work.
I noticed that when an InterruptedException is caught, we set the interrupt flag back using Thread.currentThread().interrupt(). Should we not also throw some exception, so that the higher level code, is aware than an InterruptedException was caught and handled by lower level code ? Something like https://www.yegor256.com/2015/10/20/interrupted-exception.html (check towards the end) He's just throwing a RuntimeException, we could have custom exceptions, depending on the use-case.