Add QuickAction node - Githubissues

dehsgr / node-red-contrib-evohome

This provides nodes for controlling Honeywell Evohome

ISC License

5 stars 7 forks source link

Add QuickAction node #18

Closed rathga closed 1 year ago

rathga commented 1 year ago

I am writing a flow to combine Life360 events (i.e. leaving my house) with starting and stopping the evohome 'Away' quick action, so I have added a QuickAction node to implement this. Let me know if it looks good.

rathga commented 1 year ago

Thanks @dehsgr !

All done except:

evohome-control.js: fixing up the indentation was intentional but I see my editor has spammed spaces instead of tabs, so I've fixed that bit
evohome-quickaction.js: line 21 node.log(...) seems consistent log level with evohome-control.js? As does the "evohome failed" warnings? Have I misunderstood? I have updated line 20 to debug.

Let me know if you agree with those, happy either way.

Cheers Richard

dehsgr commented 1 year ago

Thanks again, @rathga. I finally merge and publish a new version ASAP.