search

deiger / Alarm

Code to connect and control alarms by PIMA.
GNU General Public License v3.0
17 stars 11 forks source link

Allow disabling of disarm command #5

Closed gibsonlp closed 3 years ago

gibsonlp commented 4 years ago

Hi. I Added a small change that allows the disabling of the disarm command. I have the alarm code running on a more tightly secure host than my home assistant and I only wish to know the status of the system and lock it in case and I forgot to do so, not disarm it when I am not at home.

gibsonlp commented 4 years ago

Thanks, good catch, I had no idea that you can change arm states without disarming. Maybe it's worthwhile to improve on this to disable re-arm as well in these cases, I'll check it out.

The idea (at least in my environment) is that I wish to be able to arm the alarm from my bed if I forgot to do it, but disarm would only possible on the physical keyboard with the code. So if someone hacks my smart home he will not be able to disarm the alarm so easily (pima server runs on another node). I think that it might be useful for other paranoid people which is why I thought to send a pull request.

deiger commented 4 years ago

It seems to me like a significant overkill - the idea someone will manage to hack into your network, then sniff the command sent to arm the device (mind that even knowing that you use this script isn't enough, they really need to find the UUID key), and use that to call the disarm command. If they manage to do all that, they may just as well make the next hop, and break into the node that is physically connected to the alarm. In any case, for your use-case you may want to check the current status before accepting the arm command.