search

deinstapel / cursive-tabs

Tabs for gyscos/cursive views 🖥️
BSD 3-Clause "New" or "Revised" License
24 stars 8 forks source link

Remove the K: Copy constraint, make it Clone instead #10

Closed matthiasbeyer closed 4 years ago

matthiasbeyer commented 4 years ago

A possible solution for #9

This is of course very hacky and everything, and possibly not the nicest solution. But as a proposal, it's an idea I guess.

jwuensche commented 4 years ago

I can also take care of the changes as they are mostly small adjustments, if you're okay with that.

matthiasbeyer commented 4 years ago

Fixed the merge conflict by rebasing and fixed your comment.

Examples work with cargo check --examples --all for me.

jwuensche commented 4 years ago

The branch looks good now, the tests run now without troubles.I'll merge them and we can release a new version today. As for the hackiness of the solution, it's alright. We might want to restructure this code to reduce some of the clones, but we can do this later on.

Thanks so much for your work on this :smile:

matthiasbeyer commented 4 years ago

Awesome, thank you very much!