search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

ref(build.go): pulling slugbuilder storage params out #131

Closed arschles closed 8 years ago

arschles commented 8 years ago

and representing the git sha in a struct to do so

Fixes #130 Makes progress on #132

krancour commented 8 years ago

LGMT from a perspective of all the refactoring you have done and the fix on URL formatting. I'm still not sure that this will address the apparent problem of built slugs not being uploaded at all to object storage, but the root cause of that isn't actually clear to me.

arschles commented 8 years ago

@krancour thanks for looking. The root problem was that the push URL didn't have /git/... in it, and also wasn't using the full git sha (both fixed in https://github.com/arschles/builder/commit/1e4f08f0eae7c0efecefa4047b3ecd8fb5af72b4). The rest of this PR involved making the necessary refactors to be able to add regression tests for the change, and also writing those tests. This patch has lots of changes, but IMO they're in the name of better testing of the git-receive hook and still scoped tightly.

Also, this fixes git pushes as of yesterday. We still lack the cross-component (AKA end-to-end) testing to verify this works in CI, but that's in the works. Also, a fix for https://github.com/deis/workflow/issues/315 should eliminate regressions on this particular issue going forward.

adamreese commented 8 years ago

Still a WIP?

arschles commented 8 years ago

Nope, just updated the title