search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Proposal: refactor cookoo out of the builder #152

Closed arschles closed 8 years ago

arschles commented 8 years ago

I believe that github.com/Masterminds/cookoo represents a barrier to entry and therefore raises the barrier to entry for contributions to the builder codebase. Removing it as a dependency would lower this barrier.

@technosophos thoughts? @smothiki I know that you were considering doing this refactor.

smothiki commented 8 years ago

Out of scope for v2 beta. Now builder has evolved as a single process and using more libraries to talk to API endpoints rather than a bunch of binaries executed in a single shell script, I think moving away from cookoo helps in better refactoring of builder code base.

technosophos commented 8 years ago

I agree that we should do it. And I agree that it has to be post-v2.0.0.

krancour commented 8 years ago

Speaking for myself, that would make me more comfortable hacking on builder as well. Big +1

aledbf commented 8 years ago

:+1:

kmala commented 8 years ago

fixed in #316