Closed arschles closed 8 years ago
Seeing my logs being spewed full of messages:
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Cleaner found no git directories to delete
Then I realized that debug is turned on by default. Works for me!
Note that I've manually tested this and verified it works on GKE
Tested locally on a kube-solo cluster according to the above instructions. Everything went swimmingly. :+1:
Tested Just now working
Tested on GKE as well. :+1:
LGTM x 4
Any thoughts of a similar host-level trashman? Unused / old Docker images can fill up a disk. We should look into running something like Sherdock in a daemonset in the future.
@krancour not sure what you mean by host-level trashman. Can you file an issue with details? If it's something to clean up docker images I'm all for it, but the Sherdock readme doesn't provide much detail.
Overview
This PR introduces a background goroutine that polls the Kubernetes API for the list of namespaces and compares those names with those in its local git folder. The cleaner then deletes all directories that exist locally but not in the namespace list.
Testing Instructions
To test, follow these steps:
git push
to it from repository Adeis apps:destroy -a your_app
deis
tool creates the same remote in repo B). Make sure repository B has a different set of refs from Agit push
from repo BThe push should be successful and the app should run properly.
Still TODO:
RepositoryLock
primitive in order to achieve this lockingNotes:
git push
es, effectively removing some of the functionality in #170, but still preventing concurrent git pushes. We may want to hold on this PR in order to get back to full feature parity with that introduced in #170Fixes #167