git push inconsistencies during app deletion

deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

git push inconsistencies during app deletion #235

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

An edge case in the builder right now is deletion an APP when the git push is in progress. Eventually the git push fails as the builder hooks to container fails but we are not coming back to user with an Appropriate error why the PUSH failed.

arschles commented 8 years ago

:+1:

Additionally, the intermediate state created by a push should be cleaned up. Ref #214 for part of that work

vdice commented 8 years ago

@smothiki is this still intended for the v2.0-rc1 milestone?

arschles commented 8 years ago

bumping from RC1, as this is not critical for the RC

bacongobbler commented 8 years ago

I'm fairly certain this was resolved via https://github.com/deis/controller/pull/1096. Closing for now, but if there's a specific error let's open another issue. :)