fix(storagepoll): dont poll s3 for slugfile if app type is dockerfile

deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

fix(storagepoll): dont poll s3 for slugfile if app type is dockerfile #237

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

dont poll S3 storage if build pack type is dockerfile

smothiki commented 8 years ago

closes https://github.com/deis/builder/issues/236

smothiki commented 8 years ago

size of streamed logs 39803
Waiting for the deis/dockerbuild-exotic-novelist-0dd32b0c-5505271a pod to end. Checking every 100ms for 15m0s
Done
Checking for builder pod exit code
Done
Polling the S3 server every 500ms for 5m0s for the resultant slug at git/home/exotic-novelist:git-0dd32b0c/push/slug.tgz
Build complete.
Launching app.
Launching...
Workflow request POST /v2/hooks/build

arschles commented 8 years ago

@smothiki I noticed that TestWaitForObjectMissing failed on the first test run. There may be a timing issue there, which I'll investigate. See #238