search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(procfile): get the procfile from the slug if not present #239

Closed kmala closed 8 years ago

kmala commented 8 years ago

fixes #213

arschles commented 8 years ago

@kmala can you please include some testing instructions here? Also I've added the beta milestone to this PR since #213 is under beta.

kmala commented 8 years ago

Testing: Deploying example-perl should work fine after including these changes.

mboersma commented 8 years ago

Here's how I tested this change:

  1. Build deis/slugbuilder#34 locally It's merged
  2. Push that slugbuilder image to an accessible registry
  3. Change the top of k8s_util.go in builder to reference that image, e.g.: `slugBuilderImage = "quay.io/mboersma/slugbuilder:0.0.1-20160307153438"
  4. Build deis/builder#239 (this PR) along with the above change
  5. Push that builder image to an accessible registry
  6. Modify your deis-builder-rc.yaml to reference the builder image
  7. Destroy and recreate the builder RC
  8. Test as described in deis/builder#213.
bacongobbler commented 8 years ago

@kmala good to merge

kmala commented 8 years ago

@bacongobbler i am writing few unit test for this as per @arschles suggestion.I will complete it in some time and then merge

arschles commented 8 years ago

@kmala LGTM3