search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

ref(git-receive): refactor cookoo out of the git receive func #244

Closed arschles closed 8 years ago

arschles commented 8 years ago

Ref #152

This PR is a work in progress because tests still fail. Tests have been fixed

mboersma commented 8 years ago

@arschles is this still a work-in-progress? It looks like a good refactoring to me, although needs rebasing.

arschles commented 8 years ago

@mboersma I was actually waiting for e2e to succeed, but now that it has, I'll remove the WIP from the title. After I rebase I'll ask again for another review. Thanks!

mboersma commented 8 years ago

@arschles could you rebase this so we can resolve it?

arschles commented 8 years ago

@mboersma this is obsoleted by https://github.com/deis/builder/pull/316, so I'll close when that's merged

arschles commented 8 years ago

@smothiki I'd like to close this now in favor of #316, in anticipation of that PR's merge. Reasonable to you?

arschles commented 8 years ago

Closing in favor of #316 after offline discussion with @smothiki