search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(pkg): rename workflow to controller #255

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

this broke with the change in https://github.com/deis/charts/pull/153

bacongobbler commented 8 years ago

pinging @smothiki @arschles -- do you know of any spots in dockerbuilder/slugbuilder that require information from the API server?

smothiki commented 8 years ago

You have to make changes in builder . Not required in any build pods

smothiki commented 8 years ago

https://github.com/deis/builder/blob/master/pkg/gitreceive/config.go also lot other places

bacongobbler commented 8 years ago

that's been changed in this PR :)

smothiki commented 8 years ago

Oops my apologies

smothiki commented 8 years ago

Did you manually test this ?

bacongobbler commented 8 years ago

I have not.

smothiki commented 8 years ago

Also these https://github.com/deis/builder/search?utf8=%E2%9C%93&q=workflow are not critical but helps if you can include them in this PR

bacongobbler commented 8 years ago

here is the current environment in the latest charts:

><> kd exec deis-builder-3y1mw env | grep CONTROLLER
DEIS_CONTROLLER_PORT_80_TCP_PROTO=tcp
DEIS_CONTROLLER_PORT_80_TCP_PORT=80
DEIS_CONTROLLER_SERVICE_HOST=10.247.235.46
DEIS_CONTROLLER_SERVICE_PORT=80
DEIS_CONTROLLER_PORT=tcp://10.247.235.46:80
DEIS_CONTROLLER_PORT_80_TCP_ADDR=10.247.235.46
DEIS_CONTROLLER_SERVICE_PORT_HTTP=80
DEIS_CONTROLLER_PORT_80_TCP=tcp://10.247.235.46:80

Also these https://github.com/deis/builder/search?utf8=%E2%9C%93&q=workflow are not critical but helps if you can include them in this PR

Absolutely. I'll update that :)

arschles commented 8 years ago

@bacongobbler code LGTM. I'll label as such, but post some testing instructions and I'll test if you want

bacongobbler commented 8 years ago

Testing:

What you should see on master because the builder cannot communicate with the controller:

><> git push deis master
The authenticity of host '[deis.10.245.1.3.xip.io]:2222 ([10.245.1.3]:2222)' can't be established.
ECDSA key fingerprint is eb:b6:ec:eb:a3:83:d1:b9:ef:26:c1:fc:a8:83:3f:4d.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '[deis.10.245.1.3.xip.io]:2222,[10.245.1.3]:2222' (ECDSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

A deployment with this change should work again.

arschles commented 8 years ago

@bacongobbler :heavy_check_mark: