deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Support other object storage regions #266

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

Currently, the Minio client library's MakeBucket call is the only one that supports regions. This may be enough to support other regions, but our code doesn't look for the region parameter or pass it to that MakeBucket call (see https://github.com/deis/builder/blob/master/pkg/gitreceive/build.go#L103).

For an internal look at the minio-go client logic, see the following lines:

kmala commented 8 years ago

since we want to move away from minio in rc1.This shouldn't be an issue the PR #262 is merged.

arschles commented 8 years ago

Ok, then please add Fixes #266 to that PR

kmala commented 8 years ago

fixed #262