search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Don't assign pull policy environment variables in code #293

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

Summary

We have made pull policy configurable but introduced a tiny bug.

If You Are Reporting a Bug

https://github.com/deis/builder/blob/master/pkg/git/git.go#L41 Assigning a pull policy environment variable to pullpolicy variable . If the env is not set it will have null and env config doesn't fall to defaults.

Replication Steps

Please provide a detailed list of steps to reproduce it.

  1. Create a Deis Cluster
  2. Register an app
  3. git push deis master should fail with invalid pull policy error

Also, please provide a description of the desired result after the tester completes the above steps.

  1. The app called "abcd" should be deployed
  2. kubectl get pod --namespace=abcd should show 2 pods running
  3. etc...