deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Builder shouldn't send logs from build pods unless DEBUG=true #296

Closed mboersma closed 8 years ago

mboersma commented 8 years ago

Summary

In fixing Docker app git push output for #289, it was suggested that builder itself could perhaps implement DEBUG logging output more cleanly or generically.

Related Issues

289 and deis/dockerbuilder#46.

arschles commented 8 years ago

thinking about this more, not 100% sure about this because the builder needs to output some logs from the {docker,slug}builder pod. it should be up to that pod what to send back.

admittedly a large and heavy-handed fix, #207 may help solve this. just throwing it out there