deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(slugbuilder): check for the succeded status while waiting for slugbuilder pod #304

Closed kmala closed 8 years ago

kmala commented 8 years ago

Summary of Changes

Since the only reason we need to check if the pod is started or not is to stream the logs, we can add a check to see pod completed status if the pod run has completed before we started checking.

Issue(s) that this PR Closes

Closes #199

Associated End To End Test PR(s)

Associated Documentation PR(s)

Associated Design Document(s)

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

  1. Create a Deis Cluster
  2. deploy an app
  3. you should be able to successfully deploy and should not be able to reproduce the scenario mentioned in #298

    Pull Request Hygiene TODOs

Please make sure the below checklist is complete.

arschles commented 8 years ago

@kmala #298 has issues that are directly related, and should be closed if that issue is closed:

Also, would this also solve #57?

kmala commented 8 years ago

This doesn't solve #57 and just fixes #199 . I would be closing the #298 once i am sure all the issues mentioned in it are closed