deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(git-push):handle the errors during git push #313

Closed kmala closed 8 years ago

kmala commented 8 years ago

Summary of Changes

make sure the errors are not suppressed when output is piped allowing successive pushes without a dummy commit.

Issue(s) that this PR Closes

Associated End To End Test PR(s)

Associated Documentation PR(s)

Associated Design Document(s)

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

  1. Create a Deis Cluster
  2. deploy a app which errors out.
  3. git push should fail saying remote rejected meaning you should be able to do another git push without a dummy commit.

    Pull Request Hygiene TODOs

Please make sure the below checklist is complete.

arschles commented 8 years ago

@kmala code LGTM. can you create an issue in deis/workflow-e2e to add an e2e test for this?

(I don't remember if I already asked you to do this. if I did, then ignore me)

kmala commented 8 years ago

e2e test for checking this https://github.com/deis/workflow-e2e/issues/185