deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

ref(k8s_util): change debugKey to DEIS_DEBUG #317

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

Summary of Changes

This environment variable is being introduced into the actual application build. causing libraries like the ruby gem hiredis to install differently because we are affecting the build environment.

Issue(s) that this PR Closes

Please list the issue(s) that this PR closes, similar to the below:

closes deis/workflow#178

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

  1. Create a Deis Cluster with this change as well as deis/slugbuilder#70
  2. Deploy https://github.com/matthewrudy/ruby-env.git

The app should be deployed. Before, it should fail if using a version of hiredis earlier than https://github.com/redis/hiredis/pull/418, which is what matthewrudy/ruby-env demonstrates.

Pull Request Hygiene TODOs

Please make sure the below checklist is complete.

jchauncey commented 8 years ago

@bacongobbler need to rebase this