deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Pass config to slugbuilder/dockerbuilder during builds #388

Closed mattk42 closed 8 years ago

mattk42 commented 8 years ago

Both V1 and Heroku support passing config as env vars to the builders, but this is currently missing in workflow. I would like to see this personally as some of my builds rely on specific env vars set to authenticate with external private ruby gem repositories.

arschles commented 8 years ago

To add some color on implementation details, one of the two things will need to happen to make this work:

  1. The builder needs to query something (probably the controller) to get the env vars for the app to be built and pass them down to the applicable build pod (dockerbuilder or slugbuilder)
  2. The build pod (dockerbuilder or slugbuilder, depending on the type of the build) has to do the same query as described in (1)
bacongobbler commented 8 years ago

I'm pretty sure we already do this and have been doing so since 2014. Is this untrue in master?

kmala commented 8 years ago

yes..whatever is set via deis config:set <> should be available to the build environment

felixbuenemann commented 8 years ago

It certainly works fine for me. I use a custom buildpack that references environment variables at compile time to generate an nginx config.

mattk42 commented 8 years ago

Awesome! Sorry for the confusion, I'll go ahead and close this.