feat(dockerbuilder): expose docker registry authentication credentials to dockerbuilder

deis / builder

Git server and application builder for Deis Workflow

https://deis.com

MIT License

40 stars 41 forks source link

feat(dockerbuilder): expose docker registry authentication credentials to dockerbuilder #392

Closed Joshua-Anderson closed 8 years ago

Joshua-Anderson commented 8 years ago

ref #326

This exposes docker credentials set with deis registry as a json environmental variable to dockerbuilder.

I'm working on a PR for dockerbuilder to use this environmental variable to authenticate with docker registries to allow for private base images.

deis-bot commented 8 years ago

@arschles, @smothiki and @aledbf are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

codecov-io commented 8 years ago

Current coverage is 42.29%

Merging #392 into master will increase coverage by 0.25%

@@             master       #392   diff @@
==========================================
  Files            25         25          
  Lines          1144       1149     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            481        486     +5   
  Misses          632        632          
  Partials         31         31

Powered by Codecov. Last updated by b583180...a8c2309

kmala commented 8 years ago

@Joshua-Anderson this may need to hold for time being as i am currently done with the support for replacing the internal registry with private registry( #389 ) and we haven't finalized on our approach on how to support the private registry for individual app(the current implementation using deis regsitry:set doesn't fully support private registries and we may not want to go ahead with the current approach).

Joshua-Anderson commented 8 years ago

@kmala No problem, I just saw #326 and thought it could be quickly fixed. When deis support for private registries is further along I'll take a look again and see what changes are necessary.