search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

ref(log): Log the error message when the auth to controller fails #403

Closed kmala closed 8 years ago

kmala commented 8 years ago

fixes #385

deis-bot commented 8 years ago

@smothiki, @arschles and @aledbf are potential reviewers of this pull request based on my analysis of git blame information. Thanks @kmala!

helgi commented 8 years ago

Is it possible to test this? I see it is not covered by unit tests right now

Joshua-Anderson commented 8 years ago

@kmala This is going to be replaced by #402

kmala commented 8 years ago

@Joshua-Anderson i see that even you are not logging the message....i will close this if you add it in your PR

Joshua-Anderson commented 8 years ago

@kmala I shouldn't need to because the controller-sdk-go should return an verbose error. The error message is logged, correct?

kmala commented 8 years ago

We pass the auth as a parameter(https://github.com/deis/builder/blob/3e7a785db5402cbd343a5f688d6798ecfe658efc/pkg/sshd/server.go#L69-L73) to the ssh server config https://github.com/deis/builder/blob/3e7a785db5402cbd343a5f688d6798ecfe658efc/pkg/sshd/server.go#L152-L156 and golang ssh doesn't return the proper error during an auth failure...it just sends EOF

Joshua-Anderson commented 8 years ago

Got it. I thought this was logging it to the builder logs, not to the ssh output. Will add to my PR.

Joshua-Anderson commented 8 years ago

Added this warning to #402