deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Deploys fail with PORT needs to be set in the config when using a private registry #433

Closed wearethefoos closed 8 years ago

wearethefoos commented 8 years ago

I have set up workflow to use gcr on eu.gcr.io. On workflow v2.3.0 this worked just fine with the setup below, I think, but I might have missed something.

When I deploy, I get:

Pushing to registry
Build complete.
Launching App...
remote: 2016/09/26 21:50:53 Error running git receive hook [publishing release (Unknown Error (400): {"detail":"PORT needs to be set in the config when using a private registry"})]

Below part of my generate_params.toml (key_json cleaned):

# Set the location of Workflow's Registry
#
# Valid values are:
# - on-cluster: Run registry within the Kubernetes cluster
# - off-cluster: Use registry outside the Kubernetes cluster (example: dockerhub,quay.io,self-hosted)
# - ecr: Use Amazon's ECR
# - gcr: Use Google's GCR
registry_location = "gcr"

# ...

[gcr]
key_json = '''{"actual":"key","present":"here"}'''
hostname = "eu.gcr.io"

In deis-registry-token-refresher.yaml I have:

            - name: "DEIS_REGISTRY_SECRET_PREFIX"
              value: "private-registry"

Version Info

kmala commented 8 years ago

this is expected after https://github.com/deis/controller/pull/988 which went in v2.4.2 release

wearethefoos commented 8 years ago

Thanks, I went a bit down the rabbit hole on this one. 😄

I made a couple of pulls for docs and changed the error message in the hope that it clarifies things for the future. Hope that helps anyone.