Builder v2.6 cannot work with env variables

ineu commented 7 years ago

Given the config:

=== test Config
FOO      bar

In Deis 2.9 with builder 2.6.1 (and 2.6.0)

> $ kd set image deploy/deis-builder deis-builder=quay.io/deis/builder:v2.6.0
...
> $ gp deis HEAD:master
Подсчет объектов: 12, готово.
Delta compression using up to 8 threads.
Сжатие объектов: 100% (9/9), готово.
Запись объектов: 100% (12/12), 1.08 KiB | 0 bytes/s, готово.
Total 12 (delta 3), reused 0 (delta 0)
remote: 2016/12/09 12:32:44 Error running git receive hook [error creating/updating secret test-build-env: (Secret "test-build-env" is invalid: data[FOO]: Invalid value: "FOO": must have at most 253 characters and match regex \.?[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*)]

If I go back to 2.5.5, everything is back to normal:

> $ kd set image deploy/deis-builder deis-builder=quay.io/deis/builder:v2.5.5
...
> $ gp deis HEAD:master
Подсчет объектов: 12, готово.
Delta compression using up to 8 threads.
Сжатие объектов: 100% (9/9), готово.
Запись объектов: 100% (12/12), 1.08 KiB | 0 bytes/s, готово.
Total 12 (delta 3), reused 0 (delta 0)
Starting build... but first, coffee!
-----> Restoring cache...
       Done!
-----> Ruby app detected
-----> Compiling Ruby/Rack
...

bacongobbler commented 7 years ago

I think this is due to running an older version of k8s. Can you try again with k8s v1.3.10?

ineu commented 7 years ago

Sure, will try

felixbuenemann commented 7 years ago

I think this is caused by #444.

ineu commented 7 years ago

Tried a fresh install on the

Server Version: version.Info{Major:"1", Minor:"4", GitVersion:"v1.4.4", GitCommit:"3b417cc4ccd1b8f38ff9ec96bb50a81ca0ea9d56", GitTreeState:"clean", BuildDate:"2016-10-21T02:42:39Z", GoVersion:"go1.6.3", Compiler:"gc", Platform:"linux/amd64"}

Now I have the https://github.com/deis/builder/issues/454 issue

ineu commented 7 years ago

With the fix from https://github.com/deis/builder/issues/454#issuecomment-265340858 deploy works with the builder v2.6.1. So it's either the fresh installation which helped or the 1.4 kube version

kmala commented 7 years ago

fixed in https://github.com/deis/slugbuilder/pull/126

deis / builder

Builder v2.6 cannot work with env variables #455