search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 44 forks source link

chore(glide): bump golang.org/x/crypto to 6fb0668 #474

Closed mboersma closed 7 years ago

mboersma commented 7 years ago

See https://github.com/golang/crypto/compare/b82246307bd525fde15c1df976318003716bca68...6fb066875c8002ccd49dbd9a16b522711cb8f59d

Closes #462. Maybe.

codecov-io commented 7 years ago

Codecov Report

Merging #474 into master will increase coverage by 0.24%.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   55.78%   56.02%   +0.24%     
==========================================
  Files          29       29              
  Lines        1219     1219              
==========================================
+ Hits          680      683       +3     
+ Misses        501      498       -3     
  Partials       38       38
Impacted Files Coverage Δ
pkg/healthsrv/buckets_lister.go 80% <ø> (-10%) :x:
pkg/sshd/server.go 57.22% <ø> (+2.22%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c27393d...d18ba6d. Read the comment docs.

vdice commented 7 years ago

Unfortunately, I'm still seeing panics occur from builder with this patch. Stack trace here just in case it is any different from one(s) reported in https://github.com/deis/builder/issues/462

(edit: stacktrace is different, if worth analyzing)

Accepted connection.
---> panic: runtime error: slice bounds out of range

goroutine 39667 [running]:
panic(0x1184820, 0xc4200180c0)
    /usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*dsaPrivateKey).Sign(0xc420028128, 0x1bdb320, 0xc4200156b0, 0xc42025f680, 0x14, 0x20, 0x0, 0x7c0, 0xc42025f680)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/keys.go:457 +0x3bf
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.signAndMarshal(0x1be4960, 0xc420028128, 0x1bdb320, 0xc4200156b0, 0xc42025f680, 0x14, 0x20, 0xc42012d86b, 0x12f91c4, 0x8, ...)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/server.go:159 +0x6d
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*dhGroup).Server(0xc4200b5440, 0x7f41406e2b20, 0xc420168d00, 0x1bdb320, 0xc4200156b0, 0xc420584420, 0x1be4960, 0xc420028128, 0x40df34, 0x130dbb0, ...)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/kex.go:188 +0x511
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).server(0xc4206188c0, 0x1be4920, 0xc4200b5440, 0xc420525f80, 0xc420584420, 0x1, 0x0, 0x2)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:553 +0x1db
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).enterKeyExchange(0xc4206188c0, 0xc420441420, 0xd9, 0xd9, 0xc420026f01, 0x4535a0)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:518 +0x37d
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).kexLoop(0xc4206188c0)
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:287 +0x202
created by github.com/deis/builder/vendor/golang.org/x/crypto/ssh.newServerTransport
    /go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:130 +0x262