Builder fails to cleanup object store slugs

markkwasnick commented 7 years ago

Destroying an app via Deis cli does not clean up the build slugs when app name fails to match regex.

Builder Version: 2.7.1 Storage Driver: Swift Steps to reproduce: deis destroy --app=my-app kubectl logs BUILDER --namespace=deis

Only log line written is clearing the cache: Cleaner deleting cache home/my-app/cache for app my-app

Missing the lines in code at #445

log.Info("Cleaner deleting slug %s for app %s", obj, app)

my-app had over 100 builds.

Issue is potentially the regex matching:

gitRegex, err := regexp.Compile(^/+ fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")

bacongobbler commented 7 years ago

@markkwasnick can you describe the slug tarball names in your object store? they should look something like /home/jangly-tailbone:git-11241b3a.

markkwasnick commented 7 years ago

Here are a couple

fileshome/synergy-sf:git-9aed6276/push/slug.tgz

fileshome/synergy-sf:git-9dc6342c/push/slug.tgz

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/builder#16

deis / builder