deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

cannot push app with name up to 63 characters in it #504

Closed bacongobbler closed 7 years ago

bacongobbler commented 7 years ago

While testing v2.13.0, I'm seeing this:

><> deis create this-name-has-more-than-24-characters-in-it
Creating Application... done, created this-name-has-more-than-24-characters-in-it
Git remote deis successfully created for app this-name-has-more-than-24-characters-in-it.
><> git push deis master
Counting objects: 102, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (58/58), done.
Writing objects: 100% (102/102), 22.81 KiB | 0 bytes/s, done.
Total 102 (delta 39), reused 102 (delta 39)
remote: Resolving deltas: 100% (39/39), done.
Starting build... but first, coffee!
remote: 2017/04/04 20:56:51 Error running git receive hook [creating builder pod (Pod "slugbuild-this-name-has-more-than-24-characters-in-it-e91bdc46-770088bd" is invalid: metadata.labels: Invalid value: "slugbuild-this-name-has-more-than-24-characters-in-it-e91bdc46-770088bd": must be no more than 63 characters)]
To ssh://git@deis-builder.k8s.local:2222/this-name-has-more-than-24-characters-in-it.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@deis-builder.k8s.local:2222/this-name-has-more-than-24-characters-in-it.git'

We bumped up the application name length up to 63 characters recently in https://github.com/deis/controller/pull/1198, but it appears that the builder generates names for slugbuild operations that would exceed the pod name length limit.