mattk42 commented 7 years ago

RC4 Ciphers are known to be weaker. This PR removes them, leaving all other default ciphers in place. https://www.rfc-editor.org/rfc/rfc7465.txt

deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

mboersma commented 7 years ago

Jenkins, test this please.

codecov-io commented 7 years ago

Codecov Report

Merging #518 into master will increase coverage by 0.11%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   56.37%   56.48%   +0.11%     
==========================================
  Files          29       29              
  Lines        1240     1241       +1     
==========================================
+ Hits          699      701       +2     
+ Misses        503      502       -1     
  Partials       38       38

Impacted Files	Coverage Δ
pkg/sshd/server.go	`56.9% <0%> (-0.32%)`	:arrow_down:
pkg/healthsrv/buckets_lister.go	`90% <0%> (+10%)`	:arrow_up:
pkg/healthsrv/circuit_state.go	`88.88% <0%> (+11.11%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20bbfb1...344b43e. Read the comment docs.

deis / builder

fix(builder): Remove RC4 Ciphers #518

Codecov Report